Repository navigation
Run Windows session ACL operations asynchronously - #651
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Author
|
Refreshed onto current main and updated the lifecycle fixture for the new literal-path input type. Build, source/test typechecking, lint and formatting pass; the Windows-wrapper/export suite passes 45 tests with 64 platform skips on macOS. The eight lifecycle cases use real delayed subprocesses; native Windows ACL enforcement is not claimed from that local run. Could you review the refreshed head? The current Tests workflow requires maintainer approval: https://github.com/anthropics/sandbox-runtime/actions/runs/37550153813. |
sylvesterkaczmarek
force-pushed
the
fix/windows-acl-async-647
branch
from
October 7, 2026 00:05
df584ee to
5a01b5c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #647.
Windows initialization and reset run session ACL subprocesses synchronously. A slow grant, stamp or cleanup blocks the embedding process's event loop for up to the 60-second subprocess timeout, interrupting unrelated heartbeats and requests.
Add asynchronous grant, stamp, revoke and restore helpers using the existing asynchronous subprocess runner. Await them during initialization, rollback and normal reset, preserving operation order, error codes, timeouts and per-path cleanup diagnostics.
Serialize initialization and reset so teardown cannot clear the session identity during an outstanding ACL operation. Keep synchronous cleanup for the process exit handler, where Node cannot await promises. Existing synchronous public helpers remain available.
Validation
git diff --checkpassed.