Repository navigation
ci: run the Docker legs on Node 22, not on the image's Node 18 - #643
Merged
Merged
Conversation
The two Docker legs run the built CLI with the Node that ubuntu:24.04 installs, 18.19.1, which is below what engines allows since the floor went to 22.12. They now use the runner's Node 22, bound into the container.
ronleizrowice-ant
added a commit
that referenced
this pull request
Oct 7, 2026
New to the bundle: #655, #660 and the version. #643, #639 and #630 come as squashes of what it held; in the one block git marks, the workflow's, it keeps its own side, which has the checksummed bun as well. Two cases of #655 compare two wrapped commands. Here a wrap that names mount points names a manifest of its own (#584), so the cases take that name out before they compare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #636, which raised
enginestonode >=22.12.0and moved CI to Node 22, and missed two legs. The Docker legs run the built CLI (node dist/cli.js) with the Node thatubuntu:24.04installs from apt: 18.19.1, below the floor.Why now
#630 reads the version through
import … with { type: 'json' }. Node 18.19.1 does not parse that, so with #630 both Docker legs fail: six of the seven cases,SyntaxError: Unexpected token 'with'. Seen on the draft #624, which has #630 merged in. #630's own CI has not run yet.What changes
docker-testsgets the same pinnedsetup-nodestep as the other legs, withnode-version: '22'./opt/nodeand put first onPATH.nodejsandnpmare no longer installed from apt. Still no second piped installer.node --version.Testing
This pull request's own Docker legs are the test: there is no Docker where it was written. The workflow file parses, and prettier is clean.