Repository navigation
Add Quotes around Environment Configuration - #355
Closed
FabioWidmer wants to merge 1 commit into
Closed
FabioWidmer wants to merge 1 commit into
FabioWidmer wants to merge 1 commit into
Conversation
Member
Can you open an issue first please with repro? |
Contributor
Author
Fixes #358 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the container doesn't start when for example
APP_NAMEis for exampleTest Test. Having a whitespace in the config works with the Docker environment but the script for the Laravel application does not put them which breaks the environment file there. Having quotes everywhere should keep anything as it is and additionally support special characters.