Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #421
The schema normalizer treats every dictionary as a schema. As a result, a callable's argument named
titleis removed frompropertieswhile remaining inrequired. Nested model aliases such as$defsdisappear too. Dictionary defaults and object-valued const/enum/examples are also modified.Distinguish maps of field names from schema dictionaries, and keep literal data opaque. Schema metadata titles are still removed, local model references are still inlined, and nullable normalization is retained. No public API or dependencies change.
Regression coverage
titleargument is advertised with its type and remains executable.titleand$defsfield names while its schema metadata is removed.title,$defs, and$ref.All new defect cases fail against the original implementation.
Validation
Python 3.10.17 on macOS arm64:
Live provider/MCP integration tests were not run; this change is validated using real Pydantic schemas and actual Tools registration/execution, without provider mocks or requests.
AI disclosure: implemented, reviewed against schema generation/execution callers, and tested by OpenAI Codex. No human review is claimed.