Repository navigation
Fix discarded return value from sp_matrix.tocsc() - #317
Closed
ThinkerDesigns wants to merge 2 commits into
Closed
ThinkerDesigns wants to merge 2 commits into
ThinkerDesigns wants to merge 2 commits into
Conversation
In get_sub_tree_chain(), sub_leaf_cluster.tocsc() was called but the
returned matrix was not assigned back to the variable. This means the
format conversion is silently ignored, and subsequent operations may
operate on an incorrectly-formatted sparse matrix.
Changed:
sub_leaf_cluster.tocsc()
to:
sub_leaf_cluster = sub_leaf_cluster.tocsc()
This ensures the CSC-format conversion actually takes effect before the
matrix is sliced.
In _train_sub_models(), sub_Y.tocsc() was called but the returned matrix was not assigned back to the variable. The CSC format conversion is now properly captured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In get_sub_tree_chain(), sub_leaf_cluster.tocsc() was called but the returned matrix was not assigned back to the variable. This means the format conversion is silently ignored, and subsequent operations may operate on an incorrectly-formatted sparse matrix.
Changed:
sub_leaf_cluster.tocsc()
to:
sub_leaf_cluster = sub_leaf_cluster.tocsc()
This ensures the CSC-format conversion actually takes effect before the matrix is sliced.
Fixes a silent correctness bug in distributed clustering.