Skip to content

fix: adopt Signal Android v8.24.1 - #12

Merged
purpleempress merged 1 commit into
mainfrom
fix/adopt-signal-v8.24.1
Aug 21, 2026
Merged

purpleempress merged 1 commit into
mainfrom
fix/adopt-signal-v8.24.1

Conversation

@purpleempress

Copy link
Copy Markdown
Member

summary

  • rebase the complete Vesper patch series onto Signal Android v8.24.1
  • adapt dynamic theming to Signal's inline media-send v3 flow
  • preserve public access to Vesper labs settings while retaining the new upstream deletion experiment gate
  • advance upstream.pin to v8.24.1

verification

  • python3 tools/test_export_patches.py -v (39 tests)
  • Python compilation and shell syntax checks
  • clean forced materialisation from the exported 24-patch series
  • :Signal-Android:assembleWebsiteProdRelease after the rebase
  • :Signal-Android:assembleWebsiteProdRelease again after clean rematerialisation
  • independent patch/tree/DCO review with zero non-overlay mismatches and no findings

Closes #10
Closes #11

Signed-off-by: amber <amber@flourish.ch>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2ccd626a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread upstream.pin
@@ -1 +1 @@
signal=v8.23.3
signal=v8.24.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The commit message has no Signed-off-by: trailer, while CONTRIBUTING.md requires every commit to include one as confirmation of the Developer Certificate of Origin. Add the author’s valid sign-off before this contribution is accepted.

AGENTS.md reference: AGENTS.md:L45-L45

Useful? React with 👍 / 👎.

@purpleempress
purpleempress merged commit 954ad6b into main Aug 21, 2026
1 check passed
@purpleempress
purpleempress deleted the fix/adopt-signal-v8.24.1 branch August 21, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signal v8.24.1 adoption failed Signal v8.24.0 adoption failed

1 participant