Repository navigation
[DRAFT] Accept non-string immersive product title and fractional rating - #1
Merged
Merged
Conversation
Archived google_immersive_product searches can return product_results as
{"title": {"<n>": <int>}} with no stores. ImmersiveProductResults typed
title as ?string, so Data::from() threw a TypeError.
- prepareForPipeline maps a non-string title to null
- rating is ?float (SerpApi sends fractional ratings; ?int truncated them)
- tests cover both shapes
qschmick
marked this pull request as ready for review
September 25, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
google_immersive_productsearches can returnproduct_resultsas{"title": {"<n>": <int>}}with nostores.ImmersiveProductResultstypestitleas?string, soData::from()throws aTypeErrorand the retrieve fails.prepareForPipelinenow maps atitlethat isn't a string tonull.ratingis now?float. SerpApi sends fractional ratings (e.g.4.6), which?inttruncated.Testing Instructions
vendor/bin/pest --no-coverage: 4 passed.TypeError.4instead of4.6.vendor/bin/phpstan analyse: no errors.Callouts
ratingchanges type from?intto?float, which is visible to anyone reading it.v0.0.9after merge.