Repository navigation
egress: deny CONNECT tunnels to the host API port - #40
Merged
Merged
Conversation
CONNECT to APIPort gave a workload a raw tunnel to the host API that skipped the forward path's request inspection, and an upgraded harness could not tell whether an older sidecar image still allowed it. The proxy now refuses those tunnels with 403, comparing ports by value so a HostPorts spelling cannot reopen them. harness-proxy takes a --require-capability flag that the sidecar launcher and VerifyProxyBinary always pass, so older images exit non-zero instead of running the old policy. Signed-off-by: Patrick Linnane <patrick@linnane.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONNECT to APIPort gave a workload a raw tunnel to the host API that skipped the forward path's request inspection, and an upgraded harness could not tell whether an older sidecar image still allowed it.
The proxy now refuses those tunnels with 403, comparing ports by value so a HostPorts spelling cannot reopen them. harness-proxy takes a
--require-capabilityflag that the sidecar launcher and VerifyProxyBinary always pass, so older images exit non-zero instead of running the old policy.Consumers that set APIPort for a TLS or raw TCP service must move it to HostPorts.