Conversation
Preserve Buffer Storage across collection writes, optimization, compaction, and serving reopen. Share managed memory between vector storage and RocksDB, account for Parquet buffers and retained results, and bound cache-admission fallbacks. Clarify API budget semantics and cover initialization, resource lifetimes, and database storage integration with regression tests.
6 tasks
chinaux
reviewed
Sep 21, 2026
|
|
||
| ailego::ThreadPool *query_thread_pool() { | ||
| initialize(); | ||
| if (initialize() != 0) { |
Collaborator
There was a problem hiding this comment.
src/db/sqlengine/planner/query_planner.cc:436 和 src/db/collection.cc:1939 都是每查询路径，高 QPS 多线程下 initialize()里的 mutex 会变成共享 cache line 争用点。建议加个 std::atomic 快路径。
Honor page admission reserves in capacity waits and background eviction, and recheck admission after the last wait. Propagate Flat write failures and resolve forward-store scalars without copying entire columns. Add regression coverage for pressure, failed writes, and scalar lifetimes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve Buffer Storage across collection writes, optimization, compaction, and serving reopen.
Share managed memory between vector storage and RocksDB, account for Parquet buffers and retained results, and bound cache-admission fallbacks.
Clarify API budget semantics and cover initialization, resource lifetimes, and database storage integration with regression tests.