Conversation
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
| { | ||
| Name: "dashscope-codingplan", | ||
| DisplayName: "Alibaba DashScope Coding Plan (China)", | ||
| Protocol: ProtocolOpenAIChatCompletions, | ||
| BaseURL: "https://coding.dashscope.aliyuncs.com/v1", | ||
| EnvVar: "DASHSCOPE_CODINGPLAN_KEY", |
There was a problem hiding this comment.
Missing required test coverage: Per the project rules, every new provider MUST have a corresponding TestLookupProvider_<Name>Details test in internal/llm/providers_test.go that verifies Protocol, BaseURL, EnvVar, and Models. Neither dashscope-codingplan nor dashscope-codingplan-intl has such a test. The TestListProviders_Order list was updated, but detail-level regression guards are absent.
Add a test similar to the existing TestLookupProvider_MiniMaxDetails pattern, e.g.:
func TestLookupProvider_DashScopeCodingPlanDetails(t *testing.T) {
tests := []struct {
name, wantURL, wantEnvVar string
wantProtocol Protocol
wantModels []string
}{
{
name: "dashscope-codingplan",
wantURL: "https://coding.dashscope.aliyuncs.com/v1",
wantEnvVar: "DASHSCOPE_CODINGPLAN_KEY",
wantProtocol: ProtocolOpenAIChatCompletions,
wantModels: []string{"qwen3.7-plus", "qwen3.6-plus", "kimi-k2.5", "glm-5", "MiniMax-M2.5", "qwen3.5-plus", "qwen3-max-2026-01-23", "qwen3-coder-next", "qwen3-coder-plus", "glm-4.7"},
},
{
name: "dashscope-codingplan-intl",
wantURL: "https://coding-intl.dashscope.aliyuncs.com/v1",
wantEnvVar: "DASHSCOPE_CODINGPLAN_INTL_KEY",
wantProtocol: ProtocolOpenAIChatCompletions,
wantModels: []string{"qwen3.7-plus", "qwen3.6-plus", "kimi-k2.5", "glm-5", "MiniMax-M2.5", "qwen3.5-plus", "qwen3-max-2026-01-23", "qwen3-coder-next", "qwen3-coder-plus", "glm-4.7"},
},
}
// ... assert each field
}|
Heads up — #1031 just landed on main and moved the VS Code webview and shared types into a new |
Description
Adds first-class Alibaba Cloud Coding Plan support so subscribers can configure OCR with dedicated endpoints and API keys.
dashscope-codingplananddashscope-codingplan-intlpresets for China and international endpoints.Type of Change
How Has This Been Tested?
make checkmake testmake coverage— 91.9% overall coveragemake buildAdded tests covering provider presets, credential resolution and isolation, model validation, tool-call round trips,
ocr llm test, and VS Code configuration persistence.Connectivity and tool-calling tests use local HTTP mocks. Live connectivity with a Coding Plan subscription has not been verified.
Related Issues
Closes #1388