Repository navigation
fix(database): hide bound parameters in errors - #121
Merged
Merged
Conversation
The engine did not set hide_parameters. So a StatementError or a DBAPIError message contained "[parameters: (...)]" with the values of the statement. These messages go to logs and Sentry. The engine now sets hide_parameters=True. Refs: VPTHP-128 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
|
|
olivermeyer
marked this pull request as ready for review
September 25, 2026 11:24
arne-aignx
approved these changes
Sep 25, 2026
olivermeyer
enabled auto-merge (rebase)
September 25, 2026 12:37
aig-hannes
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The engine does not set
hide_parameters, so aStatementErroror aDBAPIErrormessage contains[parameters: (...)]with the statement values. These messages go to Cloud Logging and Sentry, and the values can include job payloads, partner identifiers and URLs (VPTHP-128).How?
init_enginenow passeshide_parameters=Truetocreate_async_engineas a fixed value next toecho=False, not as a setting, because no deployment needs to turn it off. The option removes only the SQLAlchemy parameter suffix. A value that Postgres repeats in its own error text, for example in a unique-violationDETAIL, stays in the message.🤖 Generated with Claude Code