Repository navigation
Fix suppression lifetime for coroutine functions - #604
Open
adenzhou1350 wants to merge 2 commits into
Open
adenzhou1350 wants to merge 2 commits into
adenzhou1350 wants to merge 2 commits into
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@suppress_type_checkscurrently restores checking as soon as an async function returns its coroutine object, before its body runs. For example, a decoratedasync defthat callscheck_type(1, str)after anawaitstill raisesTypeCheckError.Use an async wrapper for coroutine functions and reuse the existing suppression context manager around the await. Suppression starts on execution, survives suspension, and unwinds on completion, exception or cancellation. Synchronous functions and the existing globally shared suppression semantics are unchanged; this does not introduce task-local isolation or generator support.
Validation
git diff --check: pass.typeshed.stdlib.typesimport at_decorators.py:22on baseline and candidate. No additional error is reported. Other Python versions and the Sphinx build have not been run locally.Checklist