Repository navigation
Conversation
|
coverage: 94.859% (+0.006%) from 94.853% — agammann:fix-readonly-extra-items into agronholm:master |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypedDict(extra_items=ReadOnly[int]) currently accepts extra values of any type because the ReadOnly wrapper is passed directly to the internal checker. Named fields already unwrap this qualifier, but extra fields do not.
Unwrap ReadOnly before checking extra values. Add a regression that accepts an integer and rejects a string, including the extra key in the error path.
Validation on Python 3.12: the regression fails before the fix. The full suite passes afterward (536 passed, 9 skipped, 9 expected failures), and Ruff 0.15.20 lint/format checks pass for the changed files. Mypy reports an existing missing typeshed.stdlib.types import in _decorators.py; the same error was confirmed in a clean worktree at the original commit.