Repository navigation
Conversation
agronholm
reviewed
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!
Changes
Fixes #1423.
Pause transport reads in a
finallyblock when leaving the receive wait.Cancellation previously skipped this step, allowing incoming TCP data (including
TLS ciphertext) to accumulate without an active receiver. The fix preserves
cancellation and buffered data without closing the connection.
The regression test cancels
receive()and checks that the transport haspaused reading, using the simpler test suggested in review.
Local validation of the simplified test (Windows, CPython 3.12):
and the two known environment-failing test groups.
are unchanged from the pre-simplification PR baseline. Other pre-commit hooks pass.
were not rerun for this simplified test.
No documentation update is needed: this restores the intended backpressure behavior.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchdocs/), in case of behavior changes or newfeatures
changelog.d/).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
Add a news fragment file in the
changelog.d/directory, named<issue or PR number>.<type>.rst, where<type>is one of:breaking: backwards incompatible changesadded: new featureschanged: other user-visible changesfixed: bug fixesIf, say, your patch fixes issue #123, create
changelog.d/123.fixed.rstcontaining only a brief summary of the change, like this:
The issue link and the credit for your pull request are added automatically on release.
If there's no issue linked, name the file after your pull request instead by adding the
fragment after you've created the PR.