Repository navigation
Conversation
Contributor
Author
|
@agronholm Could you take a look at this portal Future completion/cancellation fix when convenient? All 20 hosted checks pass. The regression forces the completion race with real stdlib Futures and a second thread; the recorded before/after results cover synchronous/asynchronous callables and results/exceptions. The current blocker is maintainer review; GitHub reports that the branch can be cleanly merged. |
agronholm
reviewed
Oct 14, 2026
Signed-off-by: Xucheng Zhou <209601943+adenzhou1350@users.noreply.github.com>
adenzhou1350
force-pushed
the
codex/fix-portal-future-completion-race
branch
from
October 15, 2026 06:50
8ded60f to
e8f9d6a
Compare
agronholm
reviewed
Oct 17, 2026
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!
Changes
No linked issue.
A thread can cancel the Future after
_call_func()checkscancelled()but beforeset_result()orset_exception(). The resultingInvalidStateErrorescapes the portal task and cancels its task group. Useset_running_or_notify_cancel()only when the callable has completed, so cancellation remains available while it runs and completion commits atomically.The regression now follows the review suggestion: a real stdlib Future subclass calls
cancel()immediately beforeset_result()/set_exception(), without an additional cancellation thread or sync/async parametrization. All 8 result/exception cases across the configured backends fail withInvalidStateErrorwhen the originalfrom_thread.pyis restored. With the fix,tests/test_from_thread.pypasses on native Windows CPython 3.12: 222 passed, 4 skipped, 1 existing xfail. Ruff 0.16.10 check/format andgit diff --checkpass. Full pre-commit was attempted but blocked by Windows application control while starting a hook environment; the full suite, Linux and other Python versions were not rerun for this test-only follow-up. Earlier threaded-test results are historical. Implementation and tests are AI-assisted.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchdocs/), in case of behavior changes or newfeatures
changelog.d/).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
Add a news fragment file in the
changelog.d/directory, named<issue or PR number>.<type>.rst, where<type>is one of:breaking: backwards incompatible changesadded: new featureschanged: other user-visible changesfixed: bug fixesIf, say, your patch fixes issue #123, create
changelog.d/123.fixed.rstcontaining only a brief summary of the change, like this:
The issue link and the credit for your pull request are added automatically on release.
If there's no issue linked, name the file after your pull request instead by adding the
fragment after you've created the PR.