fix(demo-03) software-only verify + add CI to run all demos#14
Merged
Conversation
Under CMCP_DEV_MODE=1 (the documented way to run the demos) verify_trace_claim returns partially_verified because hardware_attestation cannot be verified without a real TEE. verify.py exited 1 on that, so run.py (check=True) crashed the offline-verification demo on its own expected output. Treat the dev-mode case (only hardware_attestation unverified, no failure reason) as success while keeping fail-closed behaviour for real partial/failed verification. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The demos repo had no CI, so nothing verified the public quickstart demos (a dependency bump could break them silently). Runs demo-01..03 in order (demo-01 produces the claim demo-02/03 consume) under CMCP_DEV_MODE=1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CMCP_DEV_MODE=1(the documented run mode)verify.pyexited 1 onpartially_verified, sorun.py(check=True) crashed the offline-verification demo on its own expected output. Now the dev-mode case (onlyhardware_attestationunverified, no failure reason) is treated as success; real partial/failed verification still exits non-zero..github/workflows/ci.yml): the repo had no CI. Runs demo-01..03 in order on every push/PR so they cannot regress silently.Verified locally
All three demos exit 0 against cmcp-runtime 0.3.0 (CMCP_DEV_MODE=1, CMCP_BEARER_TOKEN set):
Known follow-up (not in this PR)
The demo-03 README is stale: it references
trace_record.json/issuer_pub.pem/cpsetup steps that do not match the actualrun.py/verify.pyflow (which usesworkspace/trace-claim.json+cmcp_verify). Worth a separate docs fix.🤖 Generated with Claude Code