fix(cli): force UTF-8 CLI output so status glyphs do not crash on Windows (#396)#397
Merged
Conversation
…ash on Windows The cmcp CLI prints check/cross status glyphs. Under a non-UTF-8 console (Windows cp1252) writing them raises UnicodeEncodeError, so validate-config, start, etc. exit non-zero before doing anything. Reconfigure stdout/stderr to UTF-8 at the group entry point (guarded for non-reconfigurable streams). Fixes #396. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isinstance(io.TextIOWrapper) narrows the TextIO union so mypy accepts .reconfigure; contextlib.suppress(ValueError) keeps ruff SIM105 happy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reconfigures the CLI's
stdout/stderrto UTF-8 at themaingroup entry point.Why
The CLI prints check/cross status glyphs. Under a non-UTF-8 console (Windows cp1252) writing them raises
UnicodeEncodeError, socmcp validate-config/startcrash before doing anything (onlyPYTHONUTF8=1works around it today). Surfaced while verifying theagentrust-io/examplesquickstarts on Windows.The fix is guarded (
AttributeError/ValueError) for streams that cannot be reconfigured, and keeps the nicer glyphs where the terminal supports them.Fixes #396.
🤖 Generated with Claude Code