fix(eval): compare aggregate scores over matching tasks - #3258
Open
lewismosciski wants to merge 1 commit into
Open
lewismosciski wants to merge 1 commit into
lewismosciski wants to merge 1 commit into
Conversation
|
|
Collaborator
|
@lewismosciski Hello! Please sign the CLA |
Author
Already signed the CLA. Thanks! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
RunResult.diff()averages each run's available scores independently. If baseline scores are(True, False)and current scores are(True, None), it reports 50% to 100% even though the only task graded in both runs is unchanged.Compute pass rates and numeric means from paired grades, and omit aggregate deltas when no grades overlap. Regression tests cover missing feedback, ungraded feedback, and incompatible score types.
Validation: 295 eval tests passed, 6 live-model tests deselected. Pre-commit checks passed. All 8 new cases failed before the fix.
Related issue number
None; found while checking eval result comparison.
Checks
AI assistance