MWPW-204695: Fix video play/pause interaction - #6527
Open
zagi25 wants to merge 1 commit into
Open
Conversation
Contributor
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
narcis-radu
approved these changes
Aug 20, 2026
DKos95
approved these changes
Aug 20, 2026
SilviuLCF
self-requested a review
August 20, 2026 11:44
SilviuLCF
approved these changes
Aug 20, 2026
SilviuLCF
left a comment
SilviuLCF
left a comment
Contributor
There was a problem hiding this comment.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-204695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem — Pause button doesn't stick (desktop). Clicking pause paused the video, but on every loop the canplay handler called play() again, ignoring the user's pause. Fix: made canplay (and applyRotation) skip play when data-user-paused is set. It seems that this only happens for videos that are on
loopwithoutviewportplayattribute.Resolves: MWPW-204695
Reproduce: Easiest and most reliable way to reproduce is to throttle network to slow 4g/3g, reload a page, scroll down to the video, wait for video to start playing, pause it and wait for a few seconds and video will play again even thought it was paused manually.
Test URLs: