Skip to content

[spec] Multiple substitution with classes syntax#1651

Open
khaledhosny wants to merge 1 commit into
developfrom
multiple-subst-classes
Open

[spec] Multiple substitution with classes syntax#1651
khaledhosny wants to merge 1 commit into
developfrom
multiple-subst-classes

Conversation

@khaledhosny

@khaledhosny khaledhosny commented May 9, 2023

Copy link
Copy Markdown
Collaborator

Description

Document syntax for using glyph classes in multiple substitution rules. The syntax used by GlyphsApp, and recently also supported by feaLib.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@miguelsousa

Copy link
Copy Markdown
Member

@khaledhosny Actions and other GH systems are experiencing an outage; that's why CI hasn't run yet.

@khaledhosny

Copy link
Copy Markdown
Collaborator Author

@khaledhosny Actions and other GH systems are experiencing an outage; that's why CI hasn't run yet.

This is only documentation change, though, so probably there is not much for the CI to catch anyway.

@miguelsousa

Copy link
Copy Markdown
Member

I see. Do you mind creating an issue to request supporting the new formats in makeotf?

@khaledhosny

Copy link
Copy Markdown
Collaborator Author

#1652

@khaledhosny khaledhosny changed the title Add syntax for using classes in multiple substitution rules [spec] Multiple substitution with classes syntax May 13, 2023
@skef

skef commented May 16, 2023

Copy link
Copy Markdown
Collaborator

This looks like a good extension to the syntax and we will likely add it. For now the addition seems lower priority than the ongoing VF-related work, so it will happen later. We generally try to keep the FDK current with the grammar so the doc update will happen at the same time #1652 is resolved.

@skef

skef commented May 21, 2026

Copy link
Copy Markdown
Collaborator

@khaledhosny I'm going to start directing this sort of proposal to https://github.com/adobe-type-tools/feature_file_workshops for (eventual) discussion by the broader font tools community.

How would you feel about making a PR there with this proposal? You have the language worked out already. Ideally you'd take a stab at the grammar and provide some examples, but that isn't mandatory.

Or, stepping up a level, could you take that possibility up with whoever else is relevant on your side of the fence and let us know what you're thinking, either via an issue, PR, or using the address at the link above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants