Repository navigation
chore(tooling): replace UI Turbo commands with Vite+ tasks - #459
Conversation
0xPlayerOne
left a comment
There was a problem hiding this comment.
Coordinating review status: PENDING at8e9aac00ea61f9ed5ce8988e9f0ad275e72b35da. I read the complete14-file patch. The cutover preserves declaration emit and named consumer checks, but the published evidence explicitly still lacks current-head full-test/verify:changed reruns and successful candidate cross-worktree cache proof after volatile-input exclusions. Please publish those results, including output hashes and mutation invalidation, without counting the failed baseline reuse as success. Code Foundry config/dev pin1.48.1 remains out of sync with committed1.47.1 workflow callers; permission expansion issues:read is held for explicit authorization, not to be silently applied or hidden. No source defect is asserted solely from pending checks, but I have not completed acceptance of the new cache-input behavior or granted source/merge approval. Keep draft/autoOFF; completed checked follow-ups should push directly to this owned branch.
0xPlayerOne
left a comment
There was a problem hiding this comment.
Source review APPROVED at exact head 0b4fa98. Complete original scope and workflow alignment delta personally reviewed. Existing declaration emit and consumer checks are retained. Owner reports clean-worktree cache restore with mutation miss and tampered/missing output recovery; cross-layout conservative misses remain disclosed. The user-approved permission delta adds only issues: read to validation/audit jobs. Applicable current-head CI and hosted cache qualification remain pending. Tests were inspected/reported, not executed by the coordinator. This records coordinating source approval as COMMENT, not independent GitHub APPROVE; any required formal approval remains mandatory. No merge qualification or campaign completion is implied.
0xPlayerOne
left a comment
There was a problem hiding this comment.
Personal source review APPROVED at exact head 398d3c9 after main reconciliation. I personally reviewed the complete current 18-file PR patch against current main, in addition to the previously reviewed original scope. The incoming main contains the separately reviewed/merged UI #416 and version metadata; the remaining PR scope retains Bun/Vite task orchestration, actual typecheck consumer mapping, emit preservation, explicit cache boundaries and previously approved issues:read workflow changes. No new source blocker identified in the reconciled patch.
Current-head CI and required protections still gate merge. Older-head checks do not qualify this merge head; no release or consumer upgrade is authorized by this comment. Consumer upgrades remain held until all relevant UI/Plugins/Themes PRs are merged and latest releases published. This COMMENT records coordinating source approval because the connected account cannot formally approve its own PR.
|
A demonstrated runtime-cache identity defect from Control Plane #1170 also applies here: Vite+ can replace Bun with a transparent launcher, so hashing launcher text does not fingerprint the runtime. I converted this PR to draft to prepare the same process.execPath repair and executable-equivalence regression. While pushing, main integration398d3c95 advanced the remote branch; I preserved it with a normal merge into my unpublished fix. Current-main typecheck/build/lint pass and full tests are running before a normal fast-forward push. No UI416 source was edited. Please keep auto-merge off until this exact repair head has fresh review. |
|
Runtime executable fingerprint repair is now published at 92eff69, preserving the remote398d3c95 main integration. Current-main typecheck, build, lint and full test command pass. Transparent launcher/direct executable identity regression passes. Cache keys now hash the actual executable behind launchers, matching the checked Control Plane repair; the uncached gate remains enforced. The PR is draft with auto-merge off pending review of this exact head. |
|
Production-cache qualification is included at30b2b4953b6e8c4107909d7faa3dd881c46eb0cd. Unlike the older opt-in fixture, this runs the real build task, records the producing commit, and requires all production tasks to hit on a fresh same-commit runner. Main push/manual runs may save; PRs only read. Actionlint and formatting pass. No Code Foundry config/pin changes or UI416 source edits. Exact head remains draft with auto-merge off for review. |
0xPlayerOne
left a comment
There was a problem hiding this comment.
Personal source review APPROVED at 30b2b49 after complete review of the three-file delta against the previously reviewed current-main scope. Actual process.execPath fingerprinting and independent executable-hash regression match the reviewed Control Plane repair. The new cache qualification workflow has read-only contents permission, PR restore-only behavior and saves only on non-PR default-branch success; unchanged-head fresh-runner reuse is explicitly conditional on the recorded head. No build or security gate is weakened.
CI must still qualify the current head, including the new production-build workflow. Immediate same-run cache replay is not independent proof of all hosted cache scenarios. No manual release or consumer version upgrade is performed here; the user's sequencing hold remains.
|
The user explicitly requested Themes0.10.10 in this task, followed by ready state and squash auto-merge. Draft state is intentional while preparing that update. Both UI and Workshop manifests now require^0.10.10, registry dependency metadata is regenerated, and checks are running. Auto-merge is off until the checked head is published and reviewed. No Cortana consumer version bump is included. |
0xPlayerOne
left a comment
There was a problem hiding this comment.
Source review APPROVED for exact head7f647d28ec6e5850a82f8fdd89ca75f65ff41ab1. Personally read the complete eight-file delta from reviewed30b2b495: UI/Workshop theme requirements and both source/generated registry metadata consistently advance to^0.10.10; lockfile resolves the published0.10.10 artifact and reconciles the existing UI0.142.0 workspace version. Themes #98 is merged and0.10.10 published. No new executable source or gate weakening appears in this delta. Applicable current-head qualification and conflict-free readiness are still required; older/cancelled or draft-skipped checks do not qualify it. Consumer application upgrades remain held until this UI work and its subsequent release finish.
|
Exact head 7f647d2: Themes 0.10.10 constraints and generated registry requirements updated; frozen install passed with the minimal lockfile diff. Final local receipts: bun run test = 967 passed, 57,516 assertions; bun run format:check = all 947 files formatted; bun run typecheck = all four tasks passed; bun run build = all three tasks passed (1/1 build cache hit). Lint and theme:check passed during preparation. No further edits pending. GitHub reports MERGEABLE at this exact head. Root source review of all eight changed files is recorded in the coordinating thread; enabling readiness/auto-merge per the user request. Required hosted checks remain the merge gate. |
|
Merged-main cache transfer proof complete at638f73622bed3b9e2d3a6ffa80f3ef82f0d9c0aa: trusted writer39061095703 built0/1 cacheable task then replayed1/1 and saved. Independent reader39061684803 restored that exact key and hit1/1 on its FIRST build and again on its second;3/3tasks successful. This qualifies the current executable-identity implementation across fresh hosted runners, beyond prior same-checkout warm evidence. Compiler upgrade460 is separate and still awaits its own CI. |
The root build, lint, typecheck, test and test:unit commands now use the existing Vite+ task graph. Turbo is removed, development starts Storybook directly, and verify:changed selects named typecheck tasks while retaining consumer checks. Existing JavaScript/declaration emit commands are preserved.
The library build cache now excludes generated node_modules directory listings and .vite-temp configs. The baseline macOS cross-worktree harness reproduced a miss caused by
.vite-tempdisappearing from packages/ui/node_modules; output restoration was byte-for-byte correct. The narrow exclusion is implemented; the candidate worktree proof is pending.Validation:
Workflow cutover is deliberately incomplete pending the root decision: official Code Foundry 1.48.1 sync requires
issues: readon validation/audit caller jobs. The task excludes access changes, so those generated workflow changes remain held. The dev dependency and config select 1.48.1, while committed callers remain on 1.47.1 until that decision.Draft, auto-merge off. Root owns readiness and merge. No deployment, infrastructure, credential or repository-settings changes.
Current source head
8e9aac00ea61f9ed5ce8988e9f0ad275e72b35da: Bun 1.4.3 productionorch:buildwas run from two clean Git worktrees sharing a fresh task cache. Writer: 24.221s, 0/1 hit; reader: 3.813s, 1/1 hit. A source mutation then missed on its named input. These are diagnostic samples under concurrent host load, not isolated performance benchmarks. Cross-layout clone-to-worktree execution still has a conservative root.gitlisting miss; an experiment excluding the root listing caused stale reuse and was rejected/reverted. The cache harness also passed missing/tampered-output recovery and cross-worktree positive/negative controls. Hosted production fresh-runner restore remains unqualified; the older hosted proof run only demonstrates immediate fixture replay.Approved Code Foundry caller alignment is published at
0b4fa9878eb1f1d30f59f78752a5694c7b88b3ad. The only permission additions areissues: readon validation and audit; every other permission is preserved. All four changed caller files exactly matched official configuration-rendered output. Doctor, formatting, normal hooks and remote SHA verification passed. Auto-merge remains off.