Repository navigation
test(ui): compile .tsx with the Solid DOM transform in bun test - #455
Merged
0xPlayerOne merged 1 commit intoOct 17, 2026
Merged
Conversation
Bun 1.4.3 compiles `jsx: preserve` + `jsxImportSource: solid-js` as automatic dev JSX, and solid-js/jsx-dev-runtime exports no jsxDEV, so any test that imports a .tsx module fails to link. Load the same babel-preset-solid transform the build uses through a Bun.plugin preload (root bunfig.toml for the coverage run, --preload for the package run), modelled on Cortana's solid-transform. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XSzpR2pqR4VzetRzaTw7Td
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folded into #454. Review feedback showed that landing the Bun 1.4.3 pins before this transform would leave main with failing
.tsxtests, soclaude/bun-1.4.3-pins-uinow carries these commits and this branch points at the same commit (5872098). This PR now has no changes of its own and can be closed once #454 is accepted; I have not closed it. Draft, auto-merge off.The review fixes (root
bunfig.tomlno longer preloads Babel for the dependency-free Gate scope tests, the transform is synchronous, a cold-process regression test) are described in #454.Generated by Claude Code