fix(detray): Surface sequencer in case no surfaces should be collected

[niermann999]

This is needed, in case the surface sequence buffer is empty, e.g. when MBF smoothing is enabled instead of Klaman smoothing.

--- END COMMIT MESSAGE ---

[github-actions]

📊: Physics performance monitoring for 8058dcd

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding
• 🔵️ Comparison - Truth tracking (GX2F vs KF)

❗️: Downstream build failure

• eic-shell EICrecon (cc @acts-project/epic-contacts)

[andiwand]

@niermann999 @stephenswat @paradajzblond @paulgessinger should we add (detray) and co to the title so for example in this case fix(detray): Surface sequencer in case no surfaces should be collected, otherwise from the tittle alone I would think this touches ACTS core. the title then goes into the git history and is picked up from there for the release which will likely confuse anyone looking at it since labels are gone from there

[stephenswat]

@niermann999 @stephenswat @paradajzblond @paulgessinger should we add (detray) and co to the title so for example in this case fix(detray): Surface sequencer in case no surfaces should be collected, otherwise from the tittle alone I would think this touches ACTS core. the title then goes into the git history and is picked up from there for the release which will likely confuse anyone looking at it since labels are gone from there

I fully support this. Only problem is that e.g. "refactor(detray)" takes up 18 characters, but I don't think the convention in ACTS is to strictly adhere to the 50 character commit title limit, right?

[andiwand]

right this will start to get a bit long. I don't have a good idea to avoid that. we could abbreviate refactor, I don't think it makes sense to abbreviate detray?
but we don't have a char limit on our PR titles, except what GitHub might impose on us so I think it is ok

[stephenswat]

I would just go with "refactor(detray)"; it's long but doesn't make the message unreadable.

[niermann999]

We could just call it refactor(GPU), no? Which then also covers traccc

[stephenswat]

Looks correct to me.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud