fix: Bit more consistency in usage of particles and particles_selected for…#5596
Open
pbutti wants to merge 2 commits into
Open
fix: Bit more consistency in usage of particles and particles_selected for…#5596pbutti wants to merge 2 commits into
pbutti wants to merge 2 commits into
Conversation
pbutti
changed the title
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that in some tracking algorithm examples configuration "particles_selected", see
addCKFTracks, while in others "particles" are used instead, seeaddAmbiguityResolution. We propose to be little bit more consistent, even if this code shouldn't be taken as holy grail for setting up a reconstruction pass, but more like an example.--- END COMMIT MESSAGE ---