Repository navigation
Retire AppVeyor in favor of the GitHub Actions MSVC job - #410
Merged
Merged
Conversation
The windows_msvc job in build.yml now covers the same ground as the AppVeyor build (closes #407). Remove appveyor.yml and its README badge. Also fix the windows_msvc Test step: pwsh only fails a step on the last command's exit code, so failures in every test but ReadStat_Test_readstat were silently ignored. Check each exit code explicitly. ReadStat_App now runs with --version, since without arguments it prints usage and exits 1. Drop the upload of test-suite.log, which the MSVC build never produces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shun2wang
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #407.
appveyor.ymland the AppVeyor badge from the README. Thewindows_msvcGitHub Actions job builds the same solution with the same vcpkg dependencies and runs a superset of the tests.windows_msvcTest step. pwsh only fails a step on the last command's exit code, so a failure inReadStat_App,double_decimals,dta_daysorsav_datewas silently ignored. OnlyReadStat_Test_readstat(run last) could fail the job. Each exit code is now checked explicitly.ReadStat_Appnow runs with--version. Without arguments it prints usage and exits 1, which the stricter check would treat as a failure.continue-on-error/ uploadtest-suite.logsteps. The MSVC build never produces that file.What AppVeyor covered that this PR drops: a Debug build on VS 2017. Nothing in
src/usesassert(), and the projects use$(DefaultPlatformToolset), so dropping it loses little.After merging, disable the AppVeyor project / GitHub integration.
🤖 Generated with Claude Code