Skip to content

Update VUE_MATCH with extended reference syntax - #22428

Open
Glandos wants to merge 1 commit into
WeblateOrg:mainfrom
Glandos:patch-3
Open

Glandos wants to merge 1 commit into
WeblateOrg:mainfrom
Glandos:patch-3

Conversation

@Glandos

@Glandos Glandos commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

This give positive match for @:{'key.with.special.chars'} syntax. It simply add optional @: before the curly braces group.

Extension of #8509

This give positive match for `@:{'key.with.special.chars'}` syntax. It simply add optional `@:` before the curly braces group.
@Glandos
Glandos requested a review from nijel as a code owner October 28, 2026 16:16
@nijel

nijel commented Oct 28, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-28T17:52:43.711319Z
We couldn’t complete this review. Comment @codex review to try again.
1348bdd Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nijel

nijel commented Oct 28, 2026

Copy link
Copy Markdown
Member

Can you please add tests validating the changed behavior?

Update the matcher used by the Vue format check — format.py:338. VueFormattingCheck.iter_matches() bypasses VUE_MATCH and uses VUE_BRACE_MATCH and VUE_LINK_MATCH. Consequently, this change leaves validation and highlighting unchanged: @:{'key.with.special.chars'} still matches only {'key.with.special.chars'}, and removing @: from the translation passes validation. Update the active matcher and add a regression test covering extraction and prefix removal.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants