Repository navigation
feat(vcs): configure labels and assignees on GitHub pull requests - #22383
Conversation
Add three GitHub version control parameters: a pull request assignee, assigning the GitHub account linked to the user who started the push, and comma-separated labels. Weblate adds the configured values that are missing whenever it creates or updates its pull request. The acting user is only assigned to new pull requests, so pushes to an open pull request do not pile up assignees. GitHub silently ignores users without repository access, which is expected for translators, so only a configured assignee being ignored is reported. Failures raise a PullRequestUpdateFailure alert instead of failing the push, because the pull request already exists at that point. The settings tab links rendered by crispy now carry data-bs-target, so alert links to #vcs open the version control tab. Fix WeblateOrg#8494
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 1 issue across 1 rule.
Reviewed by AccessLint, which checks every pull request for accessibility issues.
| @@ -0,0 +1,5 @@ | |||
| {% comment %}Based on crispy original, adds data-bs-target to open tabs from the URL.{% endcomment %} | |||
| <li class="nav-item"><a class="nav-link{% if 'active' in link.css_class %} active{% endif %}" | |||
There was a problem hiding this comment.
WCAG 1.3.1: <li> is not contained in a <ul>, <ol>, or <menu>.
<li> elements must be contained in a <ul>, <ol>, or <menu>.
Details
List items (<li>) only have semantic meaning inside a list container (<ul>, <ol>, or <menu>). Without a list parent, screen readers will not announce 'list with N items' or allow users to skip between items using list navigation shortcuts. Wrap <li> elements in the appropriate list container — <ul> for unordered lists, <ol> for ordered/numbered lists.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex security review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| providers = GITHUB_SOCIAL_PROVIDERS | ||
| elif ( | ||
| urlparse( | ||
| getattr(settings, "SOCIAL_AUTH_GITHUB_ENTERPRISE_API_URL", "") |
There was a problem hiding this comment.
Each of the GitHub Enterprise backends has a differently named setting.
| missing = [ | ||
| assignee | ||
| for assignee in assignees | ||
| if assignee not in assigned and assignee != acting_user |
There was a problem hiding this comment.
I'm not sure if silently ignoring acting user assignment here is a good approach.
|
Merged, thanks for your contribution! |
Add three GitHub version control parameters: a pull request assignee, assigning the GitHub account linked to the user who started the push, and comma-separated labels. Weblate adds the configured values that are missing whenever it creates or updates its pull request.
The acting user is only assigned to new pull requests, so pushes to an open pull request do not pile up assignees. GitHub silently ignores users without repository access, which is expected for translators, so only a configured assignee being ignored is reported. Failures raise a PullRequestUpdateFailure alert instead of failing the push, because the pull request already exists at that point.
The settings tab links rendered by crispy now carry data-bs-target, so alert links to #vcs open the version control tab.
Fix #8494