Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-zero-ttl-prompts.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@voltagent/core": patch
---

Honor a prompt cache TTL of zero for both global and per-prompt settings, including consecutive lookups in the same millisecond. Related to the prompt-cache correctness finding in #1493.
101 changes: 101 additions & 0 deletions packages/core/src/voltops/prompt-manager-cache.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { VoltOpsPromptManagerImpl } from "./prompt-manager";
import type { VoltOpsClientOptions } from "./types";

describe("prompt cache TTL with the prompt API client", () => {
beforeEach(() => {
vi.useFakeTimers();
vi.setSystemTime(new Date("2026-01-01T00:00:00Z"));
});

afterEach(() => {
vi.useRealTimers();
});

function createManager(promptCache?: VoltOpsClientOptions["promptCache"]) {
let revision = 0;
const fetch = vi.fn<typeof globalThis.fetch>(async () =>
Response.json({
name: "example",
type: "text",
version: ++revision,
prompt: { text: `Revision ${revision}` },
}),
);
const manager = new VoltOpsPromptManagerImpl({
baseUrl: "https://prompts.example.invalid",
fetch,
promptCache,
});
return { manager, fetch };
}

it.each([0, 1])("refetches a cached prompt with a zero TTL after %i ms", async (elapsed) => {
const { manager, fetch } = createManager();
expect((await manager.getPrompt({ promptName: "example" })).text).toBe("Revision 1");
vi.advanceTimersByTime(elapsed);

const refreshed = await manager.getPrompt({
promptName: "example",
promptCache: { ttl: 0 },
});

expect(refreshed.text).toBe("Revision 2");
expect(fetch).toHaveBeenCalledTimes(2);
});

it("does not reuse a global zero-TTL entry in the same millisecond", async () => {
const { manager, fetch } = createManager({ ttl: 0 });
await manager.getPrompt({ promptName: "example" });
const refreshed = await manager.getPrompt({ promptName: "example" });

expect(refreshed.text).toBe("Revision 2");
expect(fetch).toHaveBeenCalledTimes(2);
});

it("does not reuse a per-prompt zero-TTL entry in the same millisecond", async () => {
const { manager, fetch } = createManager();
const reference = { promptName: "example", promptCache: { ttl: 0 } };
await manager.getPrompt(reference);
const refreshed = await manager.getPrompt(reference);

expect(refreshed.text).toBe("Revision 2");
expect(fetch).toHaveBeenCalledTimes(2);
});

it("allows a positive per-prompt TTL to override a global zero TTL", async () => {
const { manager, fetch } = createManager({ ttl: 0 });
const reference = { promptName: "example", promptCache: { ttl: 2 } };
await manager.getPrompt(reference);
vi.advanceTimersByTime(1_999);
expect((await manager.getPrompt(reference)).text).toBe("Revision 1");
expect(fetch).toHaveBeenCalledTimes(1);
vi.advanceTimersByTime(2);
expect((await manager.getPrompt(reference)).text).toBe("Revision 2");
expect(fetch).toHaveBeenCalledTimes(2);
});

it("keeps the default TTL when no override is supplied", async () => {
const { manager, fetch } = createManager();
const reference = { promptName: "example" };
await manager.getPrompt(reference);
vi.advanceTimersByTime(299_999);
expect((await manager.getPrompt(reference)).text).toBe("Revision 1");
expect(fetch).toHaveBeenCalledTimes(1);
vi.advanceTimersByTime(2);
expect((await manager.getPrompt(reference)).text).toBe("Revision 2");
expect(fetch).toHaveBeenCalledTimes(2);
});

it("keeps a positive global TTL when no per-prompt override is supplied", async () => {
const { manager, fetch } = createManager({ ttl: 2 });
const reference = { promptName: "example" };
await manager.getPrompt(reference);
vi.advanceTimersByTime(1_999);
expect((await manager.getPrompt(reference)).text).toBe("Revision 1");
expect(fetch).toHaveBeenCalledTimes(1);
vi.advanceTimersByTime(2);
expect((await manager.getPrompt(reference)).text).toBe("Revision 2");
expect(fetch).toHaveBeenCalledTimes(2);
});
});
5 changes: 3 additions & 2 deletions packages/core/src/voltops/prompt-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,9 @@ export class VoltOpsPromptManagerImpl implements VoltOpsPromptManager {
if (!cached) return null;

// Use custom TTL if provided, otherwise use the TTL stored with the cached item
const effectiveTtl = customTtl ? customTtl * 1000 : cached.ttl; // Convert seconds to milliseconds if custom TTL provided
const isExpired = Date.now() - cached.fetchedAt > effectiveTtl;
const effectiveTtl = customTtl !== undefined ? customTtl * 1000 : cached.ttl;
// A zero TTL must expire even when the next lookup occurs in the same millisecond.
const isExpired = effectiveTtl === 0 || Date.now() - cached.fetchedAt > effectiveTtl;
if (isExpired) {
this.cache.delete(cacheKey);
return null;
Expand Down