[FIX] auth_saml: decrypt matching_value response to compare output - #9
Open
edy1192 wants to merge 1 commit into
Open
[FIX] auth_saml: decrypt matching_value response to compare output#9edy1192 wants to merge 1 commit into
edy1192 wants to merge 1 commit into
Conversation
edy1192
force-pushed
the
16.0-dev-fix-matching-value-return
branch
from
March 13, 2025 21:43
351f6ce to
ae284a7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #9 +/- ##
==========================================
+ Coverage 88.83% 92.42% +3.58%
==========================================
Files 115 212 +97
Lines 3028 5726 +2698
Branches 369 416 +47
==========================================
+ Hits 2690 5292 +2602
- Misses 241 290 +49
- Partials 97 144 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edy1192
force-pushed
the
16.0-dev-fix-matching-value-return
branch
from
March 13, 2025 21:49
ae284a7 to
2b7e198
Compare
response.name_id.text
Decrypt matching_value response to compare output response with
response.name_id.text. It shows AttributeError: 'NoneType' object has no
attribute 'text'.
```python
2023-09-17 02:02:54,015 4049 ERROR odoo
odoo.addons.auth_saml.controllers.main: SAML2: failure - 'NoneType'
object has no attribute 'text'
Traceback (most recent call last):
File
"/home/odoo/instance/extra_addons/server-auth/auth_saml/controllers/main.py",
line 219, in signin
.auth_saml(
File
"/home/odoo/instance/extra_addons/server-auth/auth_saml/models/res_users.py",
line 64, in auth_saml
validation = self._auth_saml_validate(provider, saml_response,
base_url)
File
"/home/odoo/instance/extra_addons/server-auth/auth_saml/models/res_users.py",
line 29, in _auth_saml_validate
return provider._validate_auth_response(token, base_url)
File
"/home/odoo/instance/extra_addons/server-auth/auth_saml/models/auth_saml_provider.py",
line 296, in _validate_auth_response
matching_value = response.name_id.text
AttributeError: 'NoneType' object has no attribute 'text'
```
Check [class SecurityContext in saml2
lib](https://github.com/IdentityPython/pysaml2/blob/master/src/saml2/sigver.py#L1186)
edy1192
force-pushed
the
16.0-dev-fix-matching-value-return
branch
from
December 29, 2025 16:45
2b7e198 to
c1b593f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decrypt matching_value response to compare output response with response.name_id.text. It shows AttributeError: 'NoneType' object has no attribute 'text'.
Check class SecurityContext in saml2 lib