Repository navigation
feat(profile): serve shareable portfolio metadata - #376
Merged
Merged
Conversation
Signed-off-by: VBTG <vuppubhanu18@gmail.com>
Collaborator
Author
|
@VarshithReddy2006 I have implemented the changes for this issue. Please review my changes and merge this PR if everything looks good. |
VarshithReddy2006
approved these changes
Nov 16, 2026
VarshithReddy2006
left a comment
Owner
There was a problem hiding this comment.
LGTM! Verified server-rendered OG shell with crawler metadata escaping, ETag caching, and nginx/vite proxy configs with passing CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #351
I added an Express route at /u/:username that serves OpenGraph and Twitter metadata from the published profile snapshot. It escapes profile text, redirects uppercase usernames to the lowercase canonical URL, and includes noindex when indexing is disabled. Browsers follow a same-origin script to the public SPA portfolio, with a link available when JavaScript is disabled. I wired the share route through Vite, Nginx, and Vercel.
I added weak ETags and a five-minute template cache backed by Redis when available. I recheck publication and privacy settings before using the cache or returning HTTP 304.
Validation
I ran 30 targeted tests covering crawler metadata, escaping, privacy changes, conditional HTTP requests, cache behavior, and signed-out SPA routing. Backend and frontend typechecks passed.
Limitations
I use the published HTTPS image when available and a static PNG otherwise. The description comes from the published snapshot. I did not verify deployed routing or live social unfurls.