fix(advanced): close the code interpreter REPL at exit so the process can terminate - #1099
Merged
Merged
Conversation
… can terminate langchain-quickjs 0.3.7 closes its QuickJS contexts from __del__ by blocking on its daemon worker thread. At interpreter finalization that thread no longer runs, so any process that built the middleware hangs on exit and the robot never learns the job suspended or finished. (cherry picked from commit 97fe15b)
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes address the shutdown hang and include regression coverage.
Pull request overview
Adds exit-time QuickJS REPL cleanup to prevent advanced code-interpreter processes from hanging during shutdown.
Changes:
- Registers REPL cleanup with
atexit. - Adds regression coverage.
- Bumps the package version to
0.18.10.
File summaries
| File | Description |
|---|---|
uv.lock |
Updates the locked package version. |
tests/agent/advanced/test_code_interpreter.py |
Tests cleanup registration. |
src/uipath_langchain/agent/advanced/code_interpreter.py |
Registers REPL cleanup at process exit. |
pyproject.toml |
Updates the package version. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
17 tasks
andreibalas-uipath
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
more details in the issue created for the upstream library: langchain-ai/deepagents#6397