Repository navigation
refactor: use the download library shared by the BMDE components - #1
Merged
Merged
Conversation
scripts/download_assets.sh sources scripts/download_lib.sh, the download logic shared by every component, whose canonical copy is in bmde (copied by make fmt, checked by make lint), so it does not drift between components.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/download_assets.shsourcesscripts/download_lib.sh, the download logic shared by every BMDE component. The canonical copy is in bmde:make fmtcopies it into each component andmake lintfails if a copy differs, so the logic can't drift between components. No change in behavior.Test plan
scripts/download_assets.shruns and checks every asset as before