fix: qtox toxcore version rc release being identified as older#206
Merged
Green-Sky merged 1 commit intoJun 2, 2026
Merged
Conversation
Contributor
|
Tip Preview URL: |
github-actions
Bot
added
the
bug
Green-Sky
force-pushed
the
fix_toxcore_rc_prerelease_check
branch
from
22e76d3 to
3cf56ea
Compare
By actually comparing the version, we can see if the dockerfiles toxcore version might not already be newer than latest toxcore release.
Green-Sky
force-pushed
the
fix_toxcore_rc_prerelease_check
branch
from
3cf56ea to
1b09369
Compare
Member
Author
|
Looks like mypy just crashes now. Ready for review. |
zoff99
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By actually comparing the version, we can see if the dockerfiles toxcore version might not already be newer than latest toxcore release.
This change is