feat(workspaces): add personal workspace archiving - #831
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (15)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThis change adds per-user workspace archiving. It stores archive timestamps on memberships, exposes archive and restore mutations, updates workspace summaries and caches, and adds active or archived workspace views with card controls. ChangesWorkspace archiving
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to No concrete merge-blocking risk remains in the personal workspace archiving flow. Sequence Diagram(s)sequenceDiagram
participant WorkspaceCard
participant ArchiveMutation
participant ArchiveServerFunction
participant WorkspaceMembership
WorkspaceCard->>ArchiveMutation: submit archive or restore status
ArchiveMutation->>ArchiveServerFunction: call validated mutation
ArchiveServerFunction->>WorkspaceMembership: update current user's archivedAt
WorkspaceMembership-->>ArchiveMutation: return workspace summary
ArchiveMutation-->>WorkspaceCard: update workspace cache and show toast
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 12 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddf6a67876
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Greptile SummaryThis change adds per-user workspace archiving and an archived collection on the workspace home page. The active-search-to-empty-archive interaction was exercised and currently displays a search-empty message instead of the archive-specific empty state. Update Confidence Score: 4/5The archive view has a reproducible empty-state messaging defect that should be corrected before release. A focused component execution reproduced one user-facing behavior issue; no security impact was observed. Files Needing Attention:
What T-Rex did
|
There was a problem hiding this comment.
All reported issues were addressed across 15 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Old course workspaces clutter the active home view, but users still need a safe way to retain and revisit them. This adds personal archiving so each member can hide a workspace without affecting collaborators or deleting data.
What was requested
Changes
archivedForCurrentUserAt./home?view=archivedcollection view with a muted top-bar filter button.Testing
pnpm exec vp checkon the 12 changed TypeScript filespnpm exec vp test --run src/features/workspaces/server/mutations.test.tspnpm db:checkgit diff --check origin/main...HEADlocalhost:3000Review Notes
Migration
0009_wild_blazing_skulladds the nullable membership archive timestamp. Workspace-levelarchivedAtremains the separate deletion lifecycle field.A full production build was not run; focused checks and the local end-to-end flow cover this change.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit