Skip to content

fix: preserve host status checks in exports - #1787

Merged
LukeGus merged 1 commit into
Termix-SSH:dev-26.11.1from
pcbeingused333:fix/c2018-status-check-export
Nov 8, 2026
Merged

LukeGus merged 1 commit into
Termix-SSH:dev-26.11.1from
pcbeingused333:fix/c2018-status-check-export

Conversation

@pcbeingused333

Copy link
Copy Markdown
Contributor

Host JSON exports omit statusCheckEnabled and statusCheckInterval. Importing the exported hosts therefore enables status checks again and resets a custom interval to the global default.

Include both fields in the common export data so SSH and remote desktop hosts retain their settings in normal and share exports. The importer already reads these fields.

Testing and validation

Added four regression cases covering SSH and remote desktop hosts in both export modes, with disabled checks and a 120-second interval, and enabled checks with a null interval. Assertions use the serialized JSON payload. Before the fix, all four cases failed; after the fix, all nine export tests pass. Only this test file was run, not the full suite.

AI assistance: this change and its regression tests were generated with Codex.

@termix-triage-bot

Copy link
Copy Markdown

AI review | Looks safe to merge

Adds statusCheckEnabled and statusCheckInterval to the host export payload so these settings survive import, with corresponding regression tests. No security or rule violations found.

Reviewed 0b66789. AI can be wrong, a maintainer still decides. Comment /termix review to run it again.

@LukeGus
LukeGus merged commit 330fc9c into Termix-SSH:dev-26.11.1 Nov 8, 2026
3 checks passed
@LukeGus LukeGus mentioned this pull request Nov 9, 2026
LukeGus added a commit that referenced this pull request Nov 9, 2026
* fix: keep the default look out of the first run plugin picker

* chore: update translations and plugin pins

* chore: update wake-on-lan readme description

* chore: use the new wake-on-lan description in the readme

* fix: stop alerts with no icon squeezing text to one word per line

* chore: add wireguard to the readme plugin table

* fix: match password field height to other inputs

* fix: drop the empty security step when no sign in plugin offers setup

* feat: rework default plugins and keep unchosen plugins off in the first run picker

* chore: rename vault to ssh certificate signer in the readme

* feat: add the operations layer for declared plugin actions

* feat: add host sections, tab embeds and the operations client to the plugin ui

* chore: bump the plugin sdk to 1.0.24

* feat: let a host click open the host page

* chore: add operations center to the plugin table

* feat: let a request approved in a plugin run by permissions

* feat: limit api keys to actions when they are made

* fix: remove plugin updates the bundled copy caught up with

* feat: shared tile grid for plugin pages and many-tile dashboard cards (SDK 1.0.26)

* feat: new bundled plugins start on only if recommended, fetch missing shipped ones

* fix: remove the partial file when a desktop download is aborted early

* fix: stop the jump host pipeline test failing under load

* fix: keep line chart time labels from overlapping

* feat: shared tile look for cards and pages, plus new page pieces in SDK 1.1.0

* fix: save every ui pref key changed in one burst so dashboard reset sticks

* fix: honor signal refreshSec when caching signal reads

* fix: plugin page clipping and badges, match select and textarea sizes

* fix: widen chart axis labels to fit long units

* fix: match select and segmented heights to inputs

* chore: add backups plugin to readme

* chore: add cron, users, packages and certificates to the plugin table

* chore: add ping to the docker image

* chore: add uptime to the plugin table

* fix: test

* chore: add web servers plugin to readme

* docs: add process manager to plugin table

* docs: add virtual machines to plugin table

* docs: add UPS Manager to the plugin table

* chore: add network devices to plugin table

* docs: add Ansible to the plugin table

* fix: remove duplicate Network Devices row

* docs: add the Git plugin to the plugin table

* docs: add Notes to the plugin table

* fix: keep bottom line on tile grids that have content below

* docs: add out-of-band plugin to readme

* chore: add storage health to the plugin list

* chore: add object storage plugin to readme

* docs: add IP-KVM to plugin list

* docs: add log search to the plugin table

* chore: add security center to the plugin list

* feat: connect policy hook so plugins can require approved access

* fix: ship the connect policy in sdk 1.1.1 and add privileged access to the readme

* chore: update translations and plugin pins

* feat: native drag of files out of the desktop app

* feat: publish Flatpak to our own signed repo on each release

* feat: shared toolbar, footer and host dot pieces for plugin UI

* fix: add spacing around trailing buttons in tab strip

* feat: plugin list rows use host list status colors

* docs: list default image plugins first, the rest in a dropdown

* chore: tier map for plugins that are not pinned yet

* fix: hide empty tile stack sections so closed editors add no lines

* fix: tile lines no longer overlap section lines, tab row button groups fit

* fix: one border color for controls, small button icons snap to whole pixels

* fix: format bundled plugin pins with prettier

* fix: send credentials with the web app manifest request (#1766)

* fix: restore the hosts import/export button label (#1767)

* fix: prefer AES-128-GCM for efficient SSH group exchange (#1776)

* fix: expose host editing through the plugin shell bridge (#1778)

* feat: add macOS menu bar icon options (#1779)

* fix(build): ship the arm64 and armv7l sharp binaries in the Linux builds (#1771)

The Linux job runs on x64, so npm ci only installs @img/sharp-linux-x64 and
@img/sharp-libvips-linux-x64. The arm64 and armv7l AppImages then carry x64
binaries and fail to load sharp on start. Install the arm packages at the
versions sharp declares, as the Windows and macOS jobs already do.

Fixes #1769

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

* feat: add Cmd-B sidebar toggle shortcut (#1775)

Co-authored-by: Dr. Lukas Metzger <lukas@mba.lan>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* feat: let plugins store a CA-signed certificate on a credential (#1764)

A credential that carries an SSH key can already hold a CA-signed
certificate, but the only way to fill it in is the credentials editor.
A plugin that issues certificates has no way to keep the credential in
step, so after a renewal it keeps presenting the previous certificate
and the connection fails much later with a generic authentication error.

ctx.credentials.setSshKeyCertificate stores one on a key credential the
acting user owns, or clears it with null. It needs credentials:write and
the core credentials.update permission, refuses anything that is not a
key credential because core never sends a certificate for the other auth
types, and is audited like the other ctx.credentials writes.

Co-authored-by: Stefan Wienert <stefan@piratopedia.de>
Co-authored-by: LukeGus <bugattiguy527@gmail.com>

* fix: only run shell keybinding defaults from the shell

* chore: changelog for merged PRs

* fix: leave guest ticks out of the cpu total (Plugin-Host-Metrics#24)

* fix: pass saved password flags to plugin hosts (Plugin-SSH-Terminal#57)

* fix: quit on close on GNOME (#1781)

* feat: keep the mouse back button from leaving Termix (#1770)

* feat: let plugin sync entities merge a row made on both sides (matchOn)

* feat: browser and mouse back move between used tabs (#1770)

* feat: admin switch to block saved logins, hash session tokens (#1753)

* feat: tell login method UIs which login page they are on

* feat: let auth plugins link identities to existing accounts

* feat: let signed in users prove a second factor for connect rules

* feat: keep a shared host login on the desktop only (#1749)

* fix: don't serve a cached read that started before a change (#1783)

Fixes #1782

* chore: changelog entry for #1782

* chore: sync lockfile with sdk version

* fix: never hand out an unreadable generated ssh key

* fix: use page background for the add tiles panel

* fix: remove half written plugin dist when a build fails

* fix: list the hosts each operation fits in the catalog

* chore: name the entity in sync read warnings (Plugin-Sync#8)

* fix: replace older shipped plugins from the linked server (#1785)

* fix: show all companions on host page terminal

* fix: side nav divider spans the full width

* fix: use one fill and solid border for inputs, selects, tabs and menus

* fix: make inline views full width

* fix: keep plugin ssh pools per user and refuse half signed in sessions

* feat: check setting permissions on every host settings write, add enablePermission

* fix: clean errors for empty bodies, bad ids on postgres and mysql, half run mysql migrations

* fix: shell, settings and accessibility fixes from the release test

* fix: keep host status checks in exports (#1787)

* chore: changelog for export status checks

* chore: update sdk ui export snapshot

* chore: update translations and plugin pins

---------

Co-authored-by: Lukas <80832688+0skater0@users.noreply.github.com>
Co-authored-by: ZacharyZcR <zacharyzcr1984@gmail.com>
Co-authored-by: alexcastgonz <82875882+pcbeingused333@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Jubayer Hoque <chamber77@proton.me>
Co-authored-by: Dr. Lukas Metzger <lukas@mba.lan>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: TheLord83 <px0isp03@wienert.cc>
Co-authored-by: Stefan Wienert <stefan@piratopedia.de>
Co-authored-by: Karanvir Khanna <86384415+Karanvir1729@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants