Feature/unreal5.7 - #2344
Conversation
Documents two issues found when building the plugin against UE 5.7: 1. AdditionalCompilerArguments is invalid in UE 5.7 BuildConfiguration.xml; use PCHMemoryAllocationFactor instead to pass /Zm to cl.exe. 2. The XGE executor ignores MaxParallelActions, causing burst-parallel PCH allocations that exhaust virtual memory commit (error 1455 / C1076). Fix: set bAllowXGE=false and MaxParallelActions=4 in BuildConfiguration.xml.
UE 5.7 no longer injects ENGINE_MAJOR_VERSION into the compiler command line; it must be pulled from Runtime/Launch/Resources/Version.h. The SharedPCH for the Editor target happens to include it transitively, but the Game target's smaller PCH does not, causing C4668 errors on any file that tests that macro without an explicit include. Also add UObject/Package.h to JSClassRegister.cpp so that UPackage is fully defined when HasAnyPackageFlags is called in the Game target (where the monolithic Engine PCH is not present). Files changed: - DefaultJSModuleLoader.cpp: add Version.h before #if ENGINE_MAJOR_VERSION - ObjectRetainer.h: add Version.h before #if ENGINE_MAJOR_VERSION - JSClassRegister.cpp: add UObject/Package.h for full UPackage definition
|
ue 5.8 released, how about adding 5.8 support? |
|
Sure! We will work on it next week. |
* feat: project specific clang-format applied * feat: Reverted the V8 to 9.4.146.24 per review * feat: correct reserved-word verification false positives 1. Anchor VerifyNoReservedWordIdentifiers regex to line-start declarations so reserved words inside JSDoc prose aren't flagged. 2. Make IsTypeScriptReservedWord case-sensitive (ESearchCase::CaseSensitive) so PascalCase UE types (Class, Enum, Function, ...) aren't wrongly flagged/escaped — TypeScript keywords are case-sensitive.
|
The |
|
The plug-in was not generating the TS types definitions of the UE classes, because some types are using TS keywords like enum. The added code just renames such types in the TS code. The latest commit is addressing the CI scripts that are executed on the cloud. |
That sounds unrelated to the UE 5.7 version? |
|
It might be a valid problem for earlier versions, but I've tested with 5.7 and I saw some types that are new and causing it. This the branch name is ue5.7. It this branch with these fixes we have a working version. If you want to back port them to 5.6 or you want to support earlier versions, feel free to do it. |
|
@getong do we need anything else to get these fixes merged? We have some updates for 5.8 as well, but let's fix everything one at a time? Anything that needs addressing to get this one resolved? |
|
It seems to me, the update is not about 5.7 and 5.8 . But it is related to some small bugfix of undiscoverd bug. so you can change your commit msg and add some test suite to describe it. |
4 participants
Properly create generates .ts type files without any TS keywords, which can cause problems.