fix: filter out bookmarked courses from @ mention - #1441
Open
qianqiang-del wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The original @ feature displays all courses, including:
Original Drawbacks
Poor User Experience:
→ Bookmarked courses cannot be modified
→ Selecting them leads to confusion as they cannot be edited
Inconsistent Functionality:
→ Displays non-operable options
→ Violates the "only show operable content" design principle
Low Efficiency:
→ Users need to manually identify which courses can be modified
→ Increases cognitive burden
Fix
Added filter condition in courseOptions calculation:
.filter((course) => course.isOwner !== false)
Filters out courses where isOwner is false,
only displays courses created by the user.
User Benefits
Clearer:
→ Only shows modifiable courses
→ Reduces user confusion
More Efficient:
→ Users don't need to identify course types
→ Can directly select and operate
More Consistent:
→ All displayed courses can be modified
→ Meets user expectations
Modified File
components/workbench/workspace/WorkspaceShell.tsx