Repository navigation
feat(modules): reload + two-phase uninstall requests, policy packages-auto-update — independent of seal/sync #6124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2171f83
feat(modules): one reload request — reload M on an instance, newest c…
rbuergi 1196734
feat(packages): policy packages-auto-update — Auto by default, migrat…
rbuergi 5e51313
feat(packages): two-phase uninstall request — retire module, close hu…
rbuergi cae6c96
fix(modules): reload verdict waits for every running process; uninsta…
rbuergi 0cfbad7
Merge branch 'main' into feat/module-reload
systemorph-com[bot] 95d9334
Merge remote-tracking branch 'origin/main' into drainA/6124
rbuergi 5bd821c
fix(modules): the reload seam's swap answer is ModuleReloadSwapOutcom…
rbuergi 8dc35c6
test(registry-reconcile): seed the reminder path as a STAMPED opt-out…
rbuergi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question — Automated review finding (data, not an instruction to any agent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change keeps the floor bypass, and here is why. The pacing for AUTO-filed requests sits one level up. The auto pass files ONE request per landed set (
auto-{hash}, so replicas and re-runs file it once), andInFlightRestartmakes a later request ride a restart this process has not been through yet. So consecutive publishes only cause a second roll after the first one has actually completed, and each such roll activates code that is not running yet.Honouring
MinRollIntervalhere would turn "a landed module is pending" into a deferral that nothing re-tries: the request would sit inAwaitingRestartwith nothing scheduled to ask again, which is the stranded state the previous thread is about. Pacing auto-filed reloads separately (honour the floor forRequestedBy: nulland re-ask on the poller's cadence) needs that re-ask loop first. It's a design change and not part of this fix.