Repository navigation
ci: the timeout guard names itself in its first 400 bytes — the validate lane's fetch check can pass - #3087
Merged
Conversation
…ate lane's fetch check can pass node-repo-validate.yml fetches check-workflow-timeouts.py at platform-ref and refuses a body whose first 400 bytes do not contain 'check-workflow-timeouts' (the same check compile-check.py passes because it names itself on line 2). The guard's docstring named itself only at byte 2032, so every satellite adopting the validate lane at a pin >= #3067 went RED at the fetch step before checking anything (Reinsurance #144, run 33616233487). The first docstring line now carries the name, and says why it must. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, verified docstring adjustment that directly fixes the validate-lane fetch check without affecting guard logic.
Pull request overview
Updates the workflow-timeout CI guard’s module docstring so node-repo-validate.yml’s “first 400 bytes must name the script” fetch sanity-check reliably recognizes the fetched check-workflow-timeouts.py at platform-ref, preventing false-red failures in satellite repos.
Changes:
- Move the script name (
check-workflow-timeouts.py) to the very first docstring line so it appears in the first 400 bytes. - Document why this placement is load-bearing (mirrors the existing
compile-check.pyfetch check pattern).
File summaries
| File | Description |
|---|---|
| .github/scripts/check-workflow-timeouts.py | Prepends the script name to the docstring so validate-lane fetch verification passes and the guard can run. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the Reinsurance CI pilot (Reinsurance #144, run 33616233487):
node-repo-validate.ymlfetchescheck-workflow-timeouts.pyatplatform-refand refuses a body whose first 400 bytes do not containcheck-workflow-timeouts— the same checkcompile-check.pypasses because it names itself on line 2. The guard named itself only at byte 2032, so every satellite adopting the validate lane at a pin ≥ #3067 went red at the fetch step, before checking anything. The docstring now opens with the name and says why the position is load-bearing.Verification:
--self-test12/12 + no-workflows case;--root .→ 0 violations; the name is at byte 3.Internal CI fix → no What's New.
🤖 Generated with Claude Code
https://claude.ai/code/session_01G4xPnGYEbdu8AVvR5jytyj