Improve documentation and dependency management for nginx-waf#37
Merged
Conversation
Up to standards ✅🟢 Issues
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finalizes the nginx-waf hardening script as v1.0.0 by improving update safety for embedded Git checkouts, ensuring cleaner rebuilds of the Nginx module, and updating project documentation/changelog accordingly.
Changes:
- Added
confirm_git_pulland integrated it into update flows for ModSecurity, ModSecurity-nginx, and CRS to avoid accidental overwrites when local changes exist. - Ensured repeatable builds by removing any existing downloaded Nginx tarball and extracted source directory before fetching/extracting again.
- Updated documentation/versioning (README beta warning removal, v1.0.0 changelog entry) and added
.gitignorerules for generated build artifacts.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hardening/Nginx WAF/nginx-waf.bash | Adds confirm_git_pull, uses it for existing clones, and cleans Nginx tarball/source dir before rebuilding. |
| hardening/Nginx WAF/README.md | Removes beta warning from the documentation. |
| hardening/Nginx WAF/CHANGELOG.md | Adds v1.0.0 release notes (prompt + cleanup + ignore rules). |
| .gitignore | Ignores ModSecurity/ModSecurity-nginx and Nginx build artifacts generated by the script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+127
to
129
| printf "%sPull anyway? This may fail or require conflict resolution. " "$C_NOTE" | ||
| read -rp "[y/N] " reply | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request marks the release of version 1.0.0 of the Nginx WAF project, transitioning it out of beta. The main improvements focus on safer update procedures for Git repositories, better cleanup of build artifacts, and enhanced documentation. The most important changes are grouped below:
Update Safety and Build Process Improvements:
confirm_git_pullfunction to prompt the user before pulling updates in existing Git checkouts when local changes are present, preventing accidental overwrites. This is now used forModSecurity,ModSecurity-nginx, and the OWASP Core Rule Set repositories. [1] [2] [3] [4]Documentation and Versioning:
v1.0.0and removed the beta warning from theREADME.md. [1] [2]Code Quality and Maintainability: