Repository navigation
Fix memory leaks in downloadAssetFile - #144
Merged
Merged
Conversation
This was referenced Oct 2, 2026
Commit cd0c569 introduced a renaming mechanic for hotloading Steam art assets, which refactored `downloadAssetFile` so that it allocates a temporary filename and returns the final filename on success. The output filename was not being freed on success, and the temporary filename was not being freed on failure.
Arcitec
changed the title
Contributor
Author
|
@doZennn @mpaterakis ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit cd0c569 introduced a renaming mechanic for hotloading Steam art assets, which refactored
downloadAssetFileso that it allocates a temporary filename and returns the final filename on success.The output filename was not being freed on success, and the temporary filename was not being freed on failure.