Momentum#1466 inbound ha proxy v2 - #864
Open
dkoerichbird wants to merge 2 commits into
Open
Conversation
Proxy_Protocol and Proxy_Protocol_Timeout had never been documented, though the option has existed since 4.2.11. Add reference pages for both, covering what the option does, that the header is mandatory once enabled, that version 1 and version 2 headers are both accepted and detected automatically, how LOCAL and unknown-family headers fall back to the real peer address, and the trust model: there is no source allowlist, so any client that can reach the endpoint can assert any client address. Link the pages from the ESMTP listener and Listeners pages, and add both options to the configuration options summary.
The pages read as though both header formats had always been accepted, and the options summary gave a single "4.2.11 and later" for the option. The option does date from 4.2.11, but only for the version 1 text header; version 2 arrives in 5.4, the next on-prem release, and is rejected before it. State both facts wherever the formats are mentioned, and name the symptom on earlier releases (connection closed without a banner) so it is searchable.
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
deepakpn
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only changes with no runtime or configuration behavior impact.
Overview
Adds Momentum 4 documentation for
Proxy_ProtocolandProxy_Protocol_Timeout, including new reference pages, rows in the configuration options summary, and short guides on the general Listeners and ESMTP_Listener pages.The
Proxy_Protocolreference explains adopting the real client IP from a PROXY header for policy, SPF, logging, and concurrency; it stresses that the header is mandatory on enabled endpoints, documents trust boundaries (no source allowlist), and calls out PROXY protocol version 2 as supported from Momentum 5.4 with automatic v1/v2 detection on the same listen socket (v2 connections fail without a banner on 5.3 and earlier).Proxy_Protocol_Timeoutdocuments the default 60s wait for a complete header and interaction with session limits.Examples show proxied vs direct traffic on separate
Listenstanzas.Reviewed by Cursor Bugbot for commit cb7dce0. Bugbot is set up for automated code reviews on this repo. Configure here.