Repository navigation
Build the frontend bundle in CI as its own job - #242
Merged
Merged
Conversation
Until now nothing on a pull request ran `npm run package`: the bundle was only ever built inside the Docker image on master, so a frontend dependency bump could be green on the PR and still break the deploy. The new job is a sibling of the Kotlin job rather than a step in front of it, because the Kotlin tests don't need frontend/output (only bootJar does) and running them in parallel keeps the Kotlin feedback as fast as before. The workflow file becomes ci.yml and is called "CI" now that it covers more than Kotlin; the Kotlin job keeps its "Build & test" name so the required-check rule on master doesn't need editing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Bensge
force-pushed
the
ci/frontend-bundle-job
branch
from
September 13, 2026 07:48
c3170c3 to
c5e9f47
Compare
Kotlin Test Results123 tests 123 ✅ 31s ⏱️ Results for commit c5e9f47. |
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nothing on a pull request currently runs
npm run package— the bundle is only built inside the Docker image on master. That's how the frontend Dependabot PRs (#233, #235, #239) showed as green without CI having touched a single line of JS; a rollup failure would only surface at deploy time.kotlin-ci.yml→ci.yml, workflow name "Kotlin CI" → "CI".frontendjob ("Frontend bundle"):setup-node24 (same major as the Dockerfile'snode:24-bookwormstage) with npm cache,npm ci,npm run packageinfrontend/.:spybot-web:testdoesn't needfrontend/output(onlybootJardoes, viaverifyFrontendAssets), so the two run in parallel and fail independently. A comment in the workflow says how to chain them via an artifact if a future job needs the real bundle.Build & testdisplay name so the required-check rule onmasterkeeps matching.After merging
Add Frontend bundle to the required status checks on
master(Settings → Branches → master), next toBuild & testandCHANGELOG.md has an entry.Test plan
Frontend bundlefinishes well beforeBuild & test(should be ~30 s)🤖 Generated with Claude Code