[3.0] Restore the blank line the section banners want around them - #9512
Merged
jdarwood007 merged 1 commit intoAug 13, 2026
Merged
Conversation
Three files are out of step with the SMF/section_comments fixer: Alert.php is missing the blank line before a banner, and Autolinker.php and Help.php each carry an extra one. Nothing has been checking. The workflow asks tj-actions/changed-files what the pull request touched and, unless that list contains .php-cs-fixer.dist.php or composer.lock, passes it to the fixer as --path-mode=intersection. A pull request that touches neither of those and does not touch these three files never looks at them, and that has been every pull request for some time. Found by a branch that does change composer.lock, which is what turns the check back into a whole-tree scan. Signed-off-by: Mathias Alberts <mathiaspapealbert@hotmail.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This change was produced by an LLM. The change, the commit message and this
description were all written by Claude (Anthropic), driven by @albertlast.
Description
Three files in
release-3.0do not match what the customSMF/section_commentsfixer produces.
Sources/Alert.phpis missing the blank line before a banner;Sources/Autolinker.phpandSources/Actions/Help.phpeach carry an extra one.Three lines in total, and
composer lint-fixwrites all of it.The interesting part is why nobody noticed.
.github/workflows/php-cs-fixer.ymlaskstj-actions/changed-fileswhat the pullrequest touched and then, on line 24:
So unless the pull request changes the fixer's own config or
composer.lock, thecheck only ever looks at the files that pull request touched. That is the right
call for speed, and it means a file can drift out of compliance and stay there
indefinitely: nothing re-checks it until somebody edits it again, or until a branch
comes along that does change one of those two files and turns the check back into a
whole-tree scan.
That is how these turned up. #9511 changes
composer.lock, so its check ran overall 1738 files and reported these three, none of which that branch goes anywhere
near.
How this was verified
vendor/bin/php-cs-fixer check --allow-risky=yesover the whole tree:Found 0 of 1684 files that can be fixed, against 3 before this change.and two removed.
check-signed-off.phppasses locally.Relationship to other PRs
Independent, and worth merging on its own. #9511 and #9326 both change
composer.lockand so both get the whole-tree scan; they stay red on these threefiles until this lands.
Issues References (Fixes|Related|Closes)