Skip to content

[3.0] Stop logging a warning for every attachment that is not a JPEG #9480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live627 merged 1 commit into from
Aug 11, 2026
Merged

[3.0] Stop logging a warning for every attachment that is not a JPEG #9480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/Graphics/Image.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,11 @@ public function createThumbnail(int $max_width, int $max_height): object|bool
}

// We don't need to create a thumbnail if one is already embedded.
if (\function_exists('exif_thumbnail') && exif_thumbnail($this->source) !== false) {
// checkForEmbeddedThumb() answered this when the image was loaded, and
// it does so without a warning: exif_thumbnail() emits one for every
// format that cannot carry an embedded thumbnail, so asking it here
// again put a row in the error log for each PNG anyone uploaded.
if ($this->embedded_thumb) {
return false;
}

Expand Down