[3.0] Theme split (wave 4, part 19) — point calendar.css at the design tokens - #9443
Merged
live627 merged 1 commit intoAug 10, 2026
Merged
Conversation
index.css was converted when the tokens landed, but calendar.css was left behind and still carried 33 hard-coded colours. Restyling the calendar therefore meant editing a stylesheet rather than a variable, and dark.css and the colour variants have nothing to reach for. Seven of them already had a token elsewhere in the theme - the #ddd borders and the #f0f4f7 table backgrounds are the window ones - so those just point at it. The rest get named tokens of their own, keeping the value they have now so that nothing changes on screen. The theme branch gives some of these different values: the header row follows the title bar rather than being its own grey, today's cell takes the lightest primary tint, and holidays hang off the primary hue so a variant re-tints them. Those are a change to how the calendar looks and belong with that change, not with naming what is already there. Every rule in calendar.css that sets a colour, a background or a border was applied to a probe element and its computed values read, on both versions: 35 rules, including the hover and calendar_today ones, all identical. calendar.rtl.css keeps its four white separator borders. There is no token that means that, and the file is due to go when the calendar moves to logical properties. Signed-off-by: Mathias Alberts <mathiaspapealbert@hotmail.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Aug 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the #7933 split, wave 4.
Calendar area.
index.csswas converted when the design tokens landed.calendar.csswas left behind andstill carried 33 hard-coded colours, so restyling the calendar means editing a
stylesheet rather than a variable, and
dark.cssand the colour variants have nothing toreach for.
Seven of them already had a token elsewhere in the theme, so those just point at it:
#ddd(11 borders)var(--window-border-color)#f0f4f7(2 table backgrounds)var(--window-bg)The rest get named tokens of their own, keeping the value they have now:
Where this differs from the theme branch
It gives some of these different values — the header row follows the title bar instead of
being its own grey, today's cell takes the lightest primary tint, and holidays hang off
--primary-color-hueso a variant re-tints them. Those change how the calendar looks andbelong with that change, not with naming what is already there. The names match, so
re-pointing them later is a one-line edit each.
The event and birthday colours are the same colour in both, but written as
hsla()there.hsl(117, 92%, 52%)comes out asrgb(31, 245, 20), one off thergb(30, 245, 20)in use,so the literals stay for now.
Checked
The acceptance test for a token conversion is that nothing moves. Every rule in
calendar.cssthat sets a colour, a background or a border was applied to a probe elementand its computed values read, on both versions — 35 rules, 0 differences, including the
:hoverand.calendar_today.events/.holidays/.birthdaysrules that cannot besampled off the page directly. Computed styles on 18 elements of the month view are
identical too.
(The calendar needs #9405 to render at all on a stock install, so it was checked with that
merged in locally.)
calendar.rtl.csskeeps its four white separator borders — there is no token that meansthat, and the file is due to go when the calendar moves to logical properties.
Issues References (Fixes|Related|Closes)
Part of #7933
Co-Authored-By: live627 john@jbrock.us