Skip to content

[3.0] Theme split (wave 4, part 14) — make the search board picker a disclosure widget #9432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live627 merged 1 commit into from
Aug 10, 2026
+16 −35
Merged

[3.0] Theme split (wave 4, part 14) — make the search board picker a disclosure widget #9432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 7 additions & 35 deletions Themes/default/Search.template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,10 @@ function template_main()
echo '
<fieldset class="flow_hidden">
<div class="roundframe alt">
<div class="title_bar">
<h4 class="titlebg">
<a href="#" id="advanced_panel_link">', Lang::getTxt('choose_board', file: 'Search'), '</a>
</h4>
<span id="advanced_panel_toggle" class="toggle_down" style="display: none;"></span>
</div>
<div class="flow_auto boardslist" id="advanced_panel_div"', !empty(Utils::$context['boards_check_all']) ? ' style="display: none;"' : '', '>
<ul>';
<details id="advanced_panel"', !empty(Utils::$context['boards_check_all']) ? '' : ' open', '>
<summary class="title_bar titlebg">', Lang::getTxt('choose_board', file: 'Search'), '</summary>
<div class="flow_auto boardslist">
<ul>';

foreach (Utils::$context['categories'] as $category) {
echo '
Expand Down Expand Up @@ -209,8 +205,9 @@ function template_main()
}

echo '
</ul>
</div><!-- #advanced_panel_div -->
</ul>
</div>
</details>
<br class="clear">
<div class="padding">
<input type="checkbox" name="all" id="check_all" value=""', !empty(Utils::$context['boards_check_all']) ? ' checked' : '', ' onclick="invertAll(this, this.form, \'brd\');">
Expand All @@ -219,31 +216,6 @@ function template_main()
</div>
</div><!-- .roundframe -->
</fieldset>';

echo '
<script>
var oAdvancedPanelToggle = new smc_Toggle({
bToggleEnabled: true,
bCurrentlyCollapsed: ', !empty(Utils::$context['boards_check_all']) ? 'true' : 'false', ',
aSwappableContainers: [
\'advanced_panel_div\'
],
aSwapImages: [
{
sId: \'advanced_panel_toggle\',
altExpanded: ', Utils::escapeJavaScript(Lang::getTxt('hide', file: 'General')), ',
altCollapsed: ', Utils::escapeJavaScript(Lang::getTxt('show', file: 'General')), '
}
],
aSwapLinks: [
{
sId: \'advanced_panel_link\',
msgExpanded: ', Utils::escapeJavaScript(Lang::getTxt('choose_board', file: 'Search')), ',
msgCollapsed: ', Utils::escapeJavaScript(Lang::getTxt('choose_board', file: 'Search')), '
}
]
});
</script>';
}

echo '
Expand Down
9 changes: 9 additions & 0 deletions Themes/default/css/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2679,6 +2679,15 @@ dl {
height: 16px;
}

/* The board picker's title bar is one element now, the summary of a details.
/* It carries both bar classes, and .titlebg comes later in this file with a
/* background of its own, so the bar's is named again here. Overflow has to stay
/* visible as well, or .titlebg clips the disclosure triangle away. */
#advanced_panel > summary {
background: var(--titlebar-bg);
cursor: pointer;
overflow: visible;
}
.boardslist > ul > li {
margin: 12px;
}
Expand Down