Skip to content

[3.0] Stop the forum offering to delete the language it falls back to #9394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdarwood007 merged 1 commit into from
Aug 8, 2026
+8 −3
Merged

[3.0] Stop the forum offering to delete the language it falls back to #9394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/Actions/Admin/Languages.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,11 @@ public function editEntries()

Utils::$context['lang_id'] = &$lang_id;

// Neither the forum's own default nor en_US can go. en_US is what
// Lang::load() falls back to for any string the chosen language is
// missing, so a forum without it has no backstop at all.
Utils::$context['can_delete_language'] = $lang_id !== 'en_US' && $lang_id !== Config::$language;

// Get all the theme data.
$themes = [
1 => [
Expand Down Expand Up @@ -792,7 +797,7 @@ function ($val1, $val2) {
}

// We no longer wish to speak this language.
if (!empty($_POST['delete_main']) && $lang_id != 'english') {
if (!empty($_POST['delete_main']) && Utils::$context['can_delete_language']) {
User::$me->checkSession();
SecurityToken::validate('admin-mlang');

Expand Down
4 changes: 2 additions & 2 deletions Themes/default/ManageLanguages.template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ function template_modify_language_entries()
<input type="submit" name="save_main" value="', Lang::getTxt('save', file: 'General'), '"', !empty(Utils::$context['lang_file_not_writable_message']) ? ' disabled' : '', ' class="button">
<input type="reset" id="reset_main" value="', Lang::getTxt('reset', file: 'General'), '" class="button">';

// Allow deleting entries. English can't be deleted though.
if (Utils::$context['lang_id'] != 'english') {
// Allow deleting entries. The default language and en_US can't go.
if (Utils::$context['can_delete_language']) {
echo '
<input type="submit" name="delete_main" value="', Lang::getTxt('delete', file: 'General'), '"', !empty(Utils::$context['lang_file_not_writable_message']) ? ' disabled' : '', ' onclick="return confirm(\'', Lang::getTxt('languages_delete_confirm', file: 'ManageSettings'), '\');" class="button">';
}
Expand Down
Loading