[3.0] Theme split (wave 3, part 7) — Rebuild the footer as a flex row - #9375
Merged
Merged
Conversation
albertlast
force-pushed
the
3.0/theme-footer
branch
from
August 5, 2026 05:56
7c9ca79 to
f8688f7
Compare
Closed
The top bar was a separate band above the header holding the user links, the language picker and the search box, which left the header itself holding nothing but the forum title and the logo. They merge: the header now has the title at one end and a user panel at the other. Keeps the search box and the language picker, which the theme branch drops from the template while leaving their CSS behind. The footer's Go up link pointed at #top_section, so it now points at Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
They hang off #top_info, which is positioned, and were anchored to its start edge. That was fine while #top_info sat at the left of the page, but it now sits at the end of the header, so a 300px wide menu ran off the right of the screen and gave the page a horizontal scrollbar on a narrow window. Anchored to the end edge instead, with logical properties so it works the same way in a right to left language. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
The menu was buried inside two nested section wrappers whose only job was padding and a rounded corner. It becomes a band of its own under the header, with a wrapper inside it lining its contents up with the rest of the page, and those two section wrappers go. The clock, the news line and the breadcrumb move up to sit directly in the content wrapper. The padding the outer section used to provide moves onto the row that needed it. The maintenance page and the profile export build their own copies of this markup, so their section wrappers go the same way. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
The copyright and the help links were a list with one of the two floated, and the links themselves were separated by literal pipe characters in the markup. They become a flex row with the copyright at one end and the links at the other, spaced by a gap rather than by punctuation, so they wrap sensibly on a narrow window. Colours, size and link states move to tokens. The background comes from the primary ramp rather than its own near-identical hex value. The profile export builds its own copy of this markup, so it follows. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
albertlast
force-pushed
the
3.0/theme-footer
branch
from
August 8, 2026 05:50
f8688f7 to
a91391b
Compare
live627
approved these changes
Aug 8, 2026
This was referenced Aug 9, 2026
live627
pushed a commit
that referenced
this pull request
Aug 9, 2026
Reverts the layout half of #9373. The top bar goes back above the header holding the user links, the language picker and the search box, and the header goes back to the forum title and the logo on their own between it and the main menu. Reported as #9423, and confirmed with the author of #7933 as the direction to take: the merged header is not what people expect of this theme, whatever the theme branch does. The maintenance page and the profile export follow the forum's header, so their wrapper goes back onto the header element with it. Everything #9374 and #9375 changed stays as it is - the menu is still a band across the page and the footer is still a flex row. The Go up link points at the top bar again, since that is the first thing on the page once more. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 7 of wave 3 of the #7933 split. Stacked on #9374 and the parts below it — the diff of this one is its last commit.
The footer was a list with one of its two items floated, and the help links inside it were separated by pipe characters written into the markup:
<li class="floatright"><a …>Help</a> | <a …>Terms and Rules</a> | <a …>Go Up ▲</a></li> <li class="copyright">…</li>It becomes a flex row: copyright at one end, links at the other, separated by a
gapinstead of punctuation. Reading order now matches visual order, and both items wrap onto their own line on a narrow window instead of colliding. Colours, size and the link states move to tokens.--footer-bgisvar(--primary-color-700), which is#38546B, where the hard-coded value was#3e5a78. That is a deliberate change rather than an oversight: it is the same colour the ramp added in #9369 already carries, and the two were near enough identical that keeping both would have meant keeping a colour that has no reason to differ.A broken selector not carried over
The theme branch has this, which is worth flagging because it looks like a working rule:
There is no comma. It parses as one descendant selector,
#footer ul.helpitems li #footer li.copyright, which requires a#footerinside a#footerand so can never match. The copyright loses its Verdana on that branch. The rule here is the working onerelease-3.0already had.Verification
Board index, logged in.
At 1401px:
At 701px both items stay inside the viewport,
x 10 → 255andx 525 → 691, with no horizontal scrollbar.Every
var()inindex.cssstill resolves againstvariables.css.Issues References (Fixes|Related|Closes)
Related to #7933.