Repository navigation
Make the simulation recorder cheap and readable while it runs - #1697
Merged
Merged
Conversation
Build no strings when an event is recorded. Record one initial-condition event per key per execution. Add solver health to ProblemExecutionEvent and write a failed line. Filter simulation events by exact model and step.
Filter by step in list_simulation_events without a helper function. Build the excluded columns for the event tables in fewer lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Reduce the recorder cost in long simulations, and let a person or an agent follow a run from
simulation_status.logwhile it runs.Changes
IS.strip_module_nameon type parameters, andmodel_nameis aSymbol.InitialConditionUpdateEventper initial-condition key per execution, with one vector entry per device. A missing value isnull.ProblemExecutionEventaddstermination_status,objective_value,solve_time_s, andexec_time_s."failed"line.list_simulation_eventsfilters by exact model and step, not by time windows.show_*functions honorwall_time, and show initial-condition events with one row per device.Requires Sienna-Platform/InfrastructureSystems.jl#656 and Sienna-Platform/InfrastructureOptimizationModels.jl#201.
Closes #915